From a74388255ced48e9dac0490acc76b782f74cc2c8 Mon Sep 17 00:00:00 2001 From: Christian Weiske Date: Wed, 8 Aug 2012 06:42:59 +0200 Subject: throw exception when connection to switchboard cannot be established --- src/callnotifier/Source/Remote.php | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) (limited to 'src/callnotifier/Source/Remote.php') diff --git a/src/callnotifier/Source/Remote.php b/src/callnotifier/Source/Remote.php index 36e468d..39b042c 100644 --- a/src/callnotifier/Source/Remote.php +++ b/src/callnotifier/Source/Remote.php @@ -21,20 +21,24 @@ class Source_Remote public function connect($ip, $port) { + if ($ip == '') { + throw new \Exception('No remote IP or hostname given.'); + } + $socket = socket_create(AF_INET, SOCK_STREAM, SOL_TCP); if ($socket === false) { - echo "socket_create() failed: reason: " - . socket_strerror(socket_last_error()) . "\n"; - } else { - echo "OK.\n"; + throw new \Exception( + 'socket_create() failed: reason: ' + . socket_strerror(socket_last_error()) + ); } - echo "Attempting to connect to '$ip' on port '$port'..."; + //echo "Attempting to connect to '$ip' on port '$port'..."; $result = socket_connect($socket, $ip, $port); if ($result === false) { - echo "socket_connect() failed.\nReason: ($result) " - . socket_strerror(socket_last_error($socket)) . "\n"; - } else { - echo "OK.\n"; + throw new \Exception( + "socket_connect() failed. Reason: " + . socket_strerror(socket_last_error($socket)) + ); } $this->socket = $socket; -- cgit v1.2.3