add function to set the selection rect (for partial selections),
[enigma2.git] / lib / gui / elistboxcontent.cpp
index 2b3c0fcd2948d230199661ba0098ddff136a59ca..d4d8f609b79d87cf09c70a32fbf88dcd11a46e66 100644 (file)
@@ -1,7 +1,7 @@
 #include <lib/gui/elistbox.h>
 #include <lib/gui/elistboxcontent.h>
 #include <lib/gdi/font.h>
-#include <Python.h>
+#include <lib/python/python.h>
 
 /*
     The basic idea is to have an interface which gives all relevant list
@@ -37,225 +37,20 @@ iListboxContent::iListboxContent(): m_listbox(0)
 void iListboxContent::setListbox(eListbox *lb)
 {
        m_listbox = lb;
+       m_listbox->setItemHeight(getItemHeight());
 }
 
-DEFINE_REF(eListboxTestContent);
-
-void eListboxTestContent::cursorHome()
-{
-       m_cursor = 0;
-}
-
-void eListboxTestContent::cursorEnd()
-{
-       m_cursor = size();
-}
-
-int eListboxTestContent::cursorMove(int count)
-{
-       m_cursor += count;
-       
-       if (m_cursor < 0)
-               cursorHome();
-       else if (m_cursor > size())
-               cursorEnd();
-       return 0;
-}
-
-int eListboxTestContent::cursorValid()
-{
-       return m_cursor < size();
-}
-
-int eListboxTestContent::cursorSet(int n)
-{
-       m_cursor = n;
-       
-       if (m_cursor < 0)
-               cursorHome();
-       else if (m_cursor > size())
-               cursorEnd();
-       return 0;
-}
-
-int eListboxTestContent::cursorGet()
-{
-       return m_cursor;
-}
-
-void eListboxTestContent::cursorSave()
-{
-       m_saved_cursor = m_cursor;
-}
-
-void eListboxTestContent::cursorRestore()
-{
-       m_cursor = m_saved_cursor;
-}
-
-int eListboxTestContent::size()
-{
-       return 10;
-}
-       
-RESULT eListboxTestContent::connectItemChanged(const Slot0<void> &itemChanged, ePtr<eConnection> &connection)
-{
-       return 0;
-}
-
-void eListboxTestContent::setSize(const eSize &size)
-{
-       m_size = size;
-}
-
-void eListboxTestContent::paint(gPainter &painter, eWindowStyle &style, const ePoint &offset, int selected)
-{
-       ePtr<gFont> fnt = new gFont("Regular", 20);
-       painter.clip(eRect(offset, m_size));
-       style.setStyle(painter, selected ? eWindowStyle::styleListboxSelected : eWindowStyle::styleListboxNormal);
-       painter.clear();
-
-       if (cursorValid())
-       {
-               painter.setFont(fnt);
-               char string[10];
-               sprintf(string, "%d.)", m_cursor);
-               
-               ePoint text_offset = offset + (selected ? ePoint(2, 2) : ePoint(1, 1));
-               
-               painter.renderText(eRect(text_offset, m_size), string);
-               
-               if (selected)
-                       style.drawFrame(painter, eRect(offset, m_size), eWindowStyle::frameListboxEntry);
-       }
-       
-       painter.clippop();
-}
-
-//////////////////////////////////////
-
-DEFINE_REF(eListboxStringContent);
-
-eListboxStringContent::eListboxStringContent()
-{
-       m_size = 0;
-       cursorHome();
-}
-
-void eListboxStringContent::cursorHome()
-{
-       m_cursor = m_list.begin();
-       m_cursor_number = 0;
-}
-
-void eListboxStringContent::cursorEnd()
-{
-       m_cursor = m_list.end();
-       m_cursor_number = m_size;
-}
-
-int eListboxStringContent::cursorMove(int count)
-{
-       if (count > 0)
-       {
-               while (count && (m_cursor != m_list.end()))
-               {
-                       ++m_cursor;
-                       ++m_cursor_number;
-                       --count;
-               }
-       } else if (count < 0)
-       {
-               while (count && (m_cursor != m_list.begin()))
-               {
-                       --m_cursor;
-                       --m_cursor_number;
-                       ++count;
-               }
-       }
-       
-       return 0;
-}
-
-int eListboxStringContent::cursorValid()
-{
-       return m_cursor != m_list.end();
-}
-
-int eListboxStringContent::cursorSet(int n)
-{
-       cursorHome();
-       cursorMove(n);
-       
-       return 0;
-}
-
-int eListboxStringContent::cursorGet()
-{
-       return m_cursor_number;
-}
-
-void eListboxStringContent::cursorSave()
-{
-       m_saved_cursor = m_cursor;
-       m_saved_cursor_number = m_cursor_number;
-}
-
-void eListboxStringContent::cursorRestore()
-{
-       m_cursor = m_saved_cursor;
-       m_cursor_number = m_saved_cursor_number;
-}
-
-int eListboxStringContent::size()
-{
-       return m_size;
-}
-       
-void eListboxStringContent::setSize(const eSize &size)
-{
-       m_itemsize = size;
-}
-
-void eListboxStringContent::paint(gPainter &painter, eWindowStyle &style, const ePoint &offset, int selected)
-{
-       ePtr<gFont> fnt = new gFont("Regular", 20);
-       painter.clip(eRect(offset, m_itemsize));
-       style.setStyle(painter, selected ? eWindowStyle::styleListboxSelected : eWindowStyle::styleListboxNormal);
-       painter.clear();
-       
-       eDebug("item %d", m_cursor_number);
-       if (cursorValid())
-       {
-               eDebug("is valid..");
-               painter.setFont(fnt);
-               
-               ePoint text_offset = offset + (selected ? ePoint(2, 2) : ePoint(1, 1));
-               
-               painter.renderText(eRect(text_offset, m_itemsize), *m_cursor);
-               
-               if (selected)
-                       style.drawFrame(painter, eRect(offset, m_itemsize), eWindowStyle::frameListboxEntry);
-       }
-       
-       painter.clippop();
-}
-
-void eListboxStringContent::setList(std::list<std::string> &list)
+int iListboxContent::currentCursorSelectable()
 {
-       m_list = list;
-       m_size = list.size();
-       cursorHome();
-       m_listbox->entryReset(false);
+       return 1;
 }
 
 //////////////////////////////////////
 
 DEFINE_REF(eListboxPythonStringContent);
 
-eListboxPythonStringContent::eListboxPythonStringContent()
+eListboxPythonStringContent::eListboxPythonStringContent(): m_itemheight(25)
 {
-       m_list = 0;
 }
 
 eListboxPythonStringContent::~eListboxPythonStringContent()
@@ -305,6 +100,19 @@ int eListboxPythonStringContent::cursorGet()
        return m_cursor;
 }
 
+int eListboxPythonStringContent::currentCursorSelectable()
+{
+       if (m_list && cursorValid())
+       {
+               ePyObject item = PyList_GET_ITEM(m_list, m_cursor);
+               if (!PyTuple_Check(item))
+                       return 1;
+               if (PyTuple_Size(item) >= 2)
+                       return 1;
+       }
+       return 0;
+}
+
 void eListboxPythonStringContent::cursorSave()
 {
        m_saved_cursor = m_cursor;
@@ -336,18 +144,31 @@ void eListboxPythonStringContent::paint(gPainter &painter, eWindowStyle &style,
 
        if (m_list && cursorValid())
        {
-               PyObject *item = PyList_GET_ITEM(m_list, m_cursor); // borrowed reference!
+               int gray = 0;
+               ePyObject item = PyList_GET_ITEM(m_list, m_cursor); // borrowed reference!
                painter.setFont(fnt);
 
                        /* the user can supply tuples, in this case the first one will be displayed. */         
                if (PyTuple_Check(item))
+               {
+                       if (PyTuple_Size(item) == 1)
+                               gray = 1;
                        item = PyTuple_GET_ITEM(item, 0);
+               }
                
-               const char *string = PyString_Check(item) ? PyString_AsString(item) : "<not-a-string>";
-               
-               ePoint text_offset = offset + (selected ? ePoint(2, 2) : ePoint(1, 1));
-               
-               painter.renderText(eRect(text_offset, m_itemsize), string);
+               if (item == Py_None)
+               {
+                       int half_height = m_itemsize.height() / 2;
+                       
+                       painter.fill(eRect(offset.x() + half_height, offset.y() + half_height - 2, m_itemsize.width() - m_itemsize.height(), 4));
+               } else
+               {
+                       const char *string = PyString_Check(item) ? PyString_AsString(item) : "<not-a-string>";
+                       ePoint text_offset = offset + (selected ? ePoint(2, 2) : ePoint(1, 1));
+                       if (gray)
+                               painter.setForegroundColor(gRGB(0x808080));
+                       painter.renderText(eRect(text_offset, m_itemsize), string);
+               }
                
                if (selected)
                        style.drawFrame(painter, eRect(offset, m_itemsize), eWindowStyle::frameListboxEntry);
@@ -356,12 +177,12 @@ void eListboxPythonStringContent::paint(gPainter &painter, eWindowStyle &style,
        painter.clippop();
 }
 
-void eListboxPythonStringContent::setList(PyObject *list)
+void eListboxPythonStringContent::setList(ePyObject list)
 {
        Py_XDECREF(m_list);
        if (!PyList_Check(list))
        {
-               m_list = 0;
+               m_list = ePyObject();
        } else
        {
                m_list = list;
@@ -375,11 +196,9 @@ void eListboxPythonStringContent::setList(PyObject *list)
 PyObject *eListboxPythonStringContent::getCurrentSelection()
 {
        if (!(m_list && cursorValid()))
-       {
-               Py_INCREF(Py_None);
-               return Py_None;
-       }
-       PyObject *r = PyList_GET_ITEM(m_list, m_cursor);
+               Py_RETURN_NONE;
+
+       ePyObject r = PyList_GET_ITEM(m_list, m_cursor);
        Py_XINCREF(r);
        return r;
 }
@@ -393,7 +212,12 @@ void eListboxPythonStringContent::invalidateEntry(int index)
 void eListboxPythonStringContent::invalidate()
 {
        if (m_listbox)
+       {
+               int s = size();
+               if ( m_cursor >= s )
+                       m_listbox->moveSelectionTo(s?s-1:0);
                m_listbox->invalidate();
+       }
 }
 
 //////////////////////////////////////
@@ -410,8 +234,8 @@ void eListboxPythonConfigContent::paint(gPainter &painter, eWindowStyle &style,
        if (m_list && cursorValid())
        {
                        /* get current list item */
-               PyObject *item = PyList_GET_ITEM(m_list, m_cursor); // borrowed reference!
-               PyObject *text = 0, *value = 0;
+               ePyObject item = PyList_GET_ITEM(m_list, m_cursor); // borrowed reference!
+               ePyObject text, value;
                painter.setFont(fnt);
 
                        /* the first tuple element is a string for the left side.
@@ -440,7 +264,7 @@ void eListboxPythonConfigContent::paint(gPainter &painter, eWindowStyle &style,
                        value = PyTuple_GET_ITEM(item, 1);
                        if (value)
                        {
-                               PyObject *args = PyTuple_New(1);
+                               ePyObject args = PyTuple_New(1);
                                PyTuple_SET_ITEM(args, 0, PyInt_FromLong(selected));
                                
                                        /* CallObject will call __call__ which should return the value tuple */
@@ -457,14 +281,14 @@ void eListboxPythonConfigContent::paint(gPainter &painter, eWindowStyle &style,
                        if (value && PyTuple_Check(value))
                        {
                                        /* convert type to string */
-                               PyObject *type = PyTuple_GET_ITEM(value, 0);
+                               ePyObject type = PyTuple_GET_ITEM(value, 0);
                                const char *atype = (type && PyString_Check(type)) ? PyString_AsString(type) : 0;
                                
                                if (atype)
                                {
                                        if (!strcmp(atype, "text"))
                                        {
-                                               PyObject *pvalue = PyTuple_GET_ITEM(value, 1);
+                                               ePyObject pvalue = PyTuple_GET_ITEM(value, 1);
                                                const char *value = (pvalue && PyString_Check(pvalue)) ? PyString_AsString(pvalue) : "<not-a-string>";
                                                painter.setFont(fnt2);
                                                if (value_alignment_left)
@@ -475,13 +299,15 @@ void eListboxPythonConfigContent::paint(gPainter &painter, eWindowStyle &style,
                                                        /* pvalue is borrowed */
                                        } else if (!strcmp(atype, "slider"))
                                        {
-                                               PyObject *pvalue = PyTuple_GET_ITEM(value, 1);
+                                               ePyObject pvalue = PyTuple_GET_ITEM(value, 1);
+                                               ePyObject psize = PyTuple_GET_ITEM(value, 2);
                                                
                                                        /* convert value to Long. fallback to -1 on error. */
                                                int value = (pvalue && PyInt_Check(pvalue)) ? PyInt_AsLong(pvalue) : -1;
+                                               int size = (pvalue && PyInt_Check(psize)) ? PyInt_AsLong(psize) : 100;
                                                
                                                        /* calc. slider length */
-                                               int width = item_right.width() * value / 100;
+                                               int width = item_right.width() * value / size;
                                                int height = item_right.height();
                                                
                                                                                                
@@ -493,7 +319,7 @@ void eListboxPythonConfigContent::paint(gPainter &painter, eWindowStyle &style,
                                                        /* pvalue is borrowed */
                                        } else if (!strcmp(atype, "mtext"))
                                        {
-                                               PyObject *pvalue = PyTuple_GET_ITEM(value, 1);
+                                               ePyObject pvalue = PyTuple_GET_ITEM(value, 1);
                                                const char *text = (pvalue && PyString_Check(pvalue)) ? PyString_AsString(pvalue) : "<not-a-string>";
                                                int xoffs = value_alignment_left ? 0 : m_seperation;
                                                ePtr<eTextPara> para = new eTextPara(eRect(offset + eSize(xoffs, 0), item_right));
@@ -502,7 +328,7 @@ void eListboxPythonConfigContent::paint(gPainter &painter, eWindowStyle &style,
                                                para->realign(value_alignment_left ? eTextPara::dirLeft : eTextPara::dirRight);
                                                int glyphs = para->size();
                                                
-                                               PyObject *plist = 0;
+                                               ePyObject plist;
                                                
                                                if (PyTuple_Size(value) >= 3)
                                                        plist = PyTuple_GET_ITEM(value, 2);
@@ -514,7 +340,7 @@ void eListboxPythonConfigContent::paint(gPainter &painter, eWindowStyle &style,
                                                
                                                for (int i = 0; i < entries; ++i)
                                                {
-                                                       PyObject *entry = PyList_GET_ITEM(plist, i);
+                                                       ePyObject entry = PyList_GET_ITEM(plist, i);
                                                        int num = PyInt_Check(entry) ? PyInt_AsLong(entry) : -1;
                                                        
                                                        if ((num < 0) || (num >= glyphs))
@@ -548,22 +374,88 @@ void eListboxPythonConfigContent::paint(gPainter &painter, eWindowStyle &style,
        painter.clippop();
 }
 
+int eListboxPythonConfigContent::currentCursorSelectable()
+{
+       return eListboxPythonStringContent::currentCursorSelectable();
+}
+
 //////////////////////////////////////
 
        /* todo: make a real infrastructure here! */
 RESULT SwigFromPython(ePtr<gPixmap> &res, PyObject *obj);
 
+eListboxPythonMultiContent::eListboxPythonMultiContent()
+{
+}
+
+eListboxPythonMultiContent::~eListboxPythonMultiContent()
+{
+       if (m_buildFunc)
+               Py_DECREF(m_buildFunc);
+}
+
+void eListboxPythonMultiContent::setSelectionClip(eRect &rect, bool update)
+{
+       if (update && m_selection_clip.valid())
+       {
+// redraw old selection
+               m_temp_clip = m_selection_clip;
+               m_selection_clip = eRect();
+               if (m_listbox)
+                       m_listbox->entryChanged(m_cursor);
+// redraw new selection
+               m_selection_clip = rect;
+               m_temp_clip = rect;
+               if (m_listbox)
+                       m_listbox->entryChanged(m_cursor);
+               m_temp_clip = eRect();
+       }
+       else
+               m_selection_clip = rect;
+}
+
 void eListboxPythonMultiContent::paint(gPainter &painter, eWindowStyle &style, const ePoint &offset, int selected)
 {
        eRect itemrect(offset, m_itemsize);
+       if (m_temp_clip.valid())
+       {
+               eRect tmp = m_temp_clip;
+               tmp.moveBy(offset);
+               itemrect &= tmp;
+       }
+
        painter.clip(itemrect);
-       style.setStyle(painter, selected ? eWindowStyle::styleListboxSelected : eWindowStyle::styleListboxNormal);
+       style.setStyle(painter, selected && !m_selection_clip.valid() ? eWindowStyle::styleListboxSelected : eWindowStyle::styleListboxNormal);
        painter.clear();
+       if (selected && m_selection_clip.valid())
+       {
+               eRect tmp = m_selection_clip;
+               tmp.moveBy(offset);
+               painter.clip(tmp);
+               style.setStyle(painter, eWindowStyle::styleListboxSelected );
+               painter.clear();
+               painter.clippop();
+       }
+
+       ePyObject items;
 
        if (m_list && cursorValid())
        {
-               PyObject *items = PyList_GET_ITEM(m_list, m_cursor); // borrowed reference!
-               
+               items = PyList_GET_ITEM(m_list, m_cursor); // borrowed reference!
+
+               if (m_buildFunc)
+               {
+                       if (PyCallable_Check(m_buildFunc))  // when we have a buildFunc then call it
+                       {
+                               if (PyTuple_Check(items))
+                                       items = PyObject_CallObject(m_buildFunc, items);
+                               else
+                                       eDebug("items is no tuple");
+                       }
+                       else
+                               eDebug("buildfunc is not callable");
+               }
+
                if (!items)
                {
                        eDebug("eListboxPythonMultiContent: error getting item %d", m_cursor);
@@ -579,7 +471,7 @@ void eListboxPythonMultiContent::paint(gPainter &painter, eWindowStyle &style, c
                int size = PyList_Size(items);
                for (int i = 1; i < size; ++i)
                {
-                       PyObject *item = PyList_GET_ITEM(items, i); // borrowed reference!
+                       ePyObject item = PyList_GET_ITEM(items, i); // borrowed reference!
                        
                        if (!item)
                        {
@@ -587,12 +479,12 @@ void eListboxPythonMultiContent::paint(gPainter &painter, eWindowStyle &style, c
                                goto error_out;
                        }
                        
-                       PyObject *px = 0, *py = 0, *pwidth = 0, *pheight = 0, *pfnt = 0, *pstring = 0, *pflags = 0;
+                       ePyObject px, py, pwidth, pheight, pfnt, pstring, pflags, pcolor, pfillColor, pborderWidth, pborderColor;
                
                        /*
                                we have a list of tuples:
                                
-                               (0, x, y, width, height, fnt, flags, "bla" ),
+                               (0, x, y, width, height, fnt, flags, "bla"[, color] ),
 
                                or, for a progress:
                                (1, x, y, width, height, filled_percent )
@@ -631,6 +523,22 @@ void eListboxPythonMultiContent::paint(gPainter &painter, eWindowStyle &style, c
                                        pflags = PyTuple_GET_ITEM(item, 6);
                                        pstring = PyTuple_GET_ITEM(item, 7);
                                }
+                               if (size > 8)
+                               {
+                                       pcolor = PyTuple_GET_ITEM(item, 8);
+                                       if (pcolor == Py_None)
+                                               pcolor=ePyObject();
+                               }
+                               if (size > 9)
+                               {
+                                       pfillColor = PyTuple_GET_ITEM(item, 9);
+                                       if (pfillColor == Py_None)
+                                               pfillColor=ePyObject();
+                               }
+                               if (size > 10)
+                                       pborderWidth = PyTuple_GET_ITEM(item, 10);
+                               if (size > 11)
+                                       pborderColor = PyTuple_GET_ITEM(item, 11);
                        }
                        
                        switch (type)
@@ -639,7 +547,7 @@ void eListboxPythonMultiContent::paint(gPainter &painter, eWindowStyle &style, c
                        {
                                if (!(px && py && pwidth && pheight && pfnt && pstring))
                                {
-                                       eDebug("eListboxPythonMultiContent received too small tuple (must be (TYPE_TEXT, x, y, width, height, fnt, flags, string[, ...])");
+                                       eDebug("eListboxPythonMultiContent received too small tuple (must be (TYPE_TEXT, x, y, width, height, fnt, flags, string, [color, ]...])");
                                        goto error_out;
                                }
                                
@@ -650,22 +558,70 @@ void eListboxPythonMultiContent::paint(gPainter &painter, eWindowStyle &style, c
                                int height = PyInt_AsLong(pheight);
                                int flags = PyInt_AsLong(pflags);
                                int fnt = PyInt_AsLong(pfnt);
-                               
+                               int bwidth = pborderWidth ? PyInt_AsLong(pborderWidth) : 0;
+
+                               if (pcolor)
+                               {
+                                       int color = PyInt_AsLong(pcolor);
+                                       painter.setForegroundColor(gRGB(color));
+                               }
+
                                if (m_font.find(fnt) == m_font.end())
                                {
                                        eDebug("eListboxPythonMultiContent: specified font %d was not found!", fnt);
                                        goto error_out;
                                }
-                               
-                               eRect r = eRect(x, y, width, height);
-                               r.moveBy(offset);
-                               r &= itemrect;
-                               
+
+                               eRect rc = eRect(x+bwidth, y+bwidth, width-bwidth*2, height-bwidth*2);
+                               rc.moveBy(offset);
+                               rc &= itemrect;
+                               painter.clip(rc);
+
+                               if (pfillColor && !selected)
+                               {
+                                       int color = PyInt_AsLong(pfillColor);
+                                       painter.setBackgroundColor(gRGB(color));
+                                       painter.clear();
+                               }
+
                                painter.setFont(m_font[fnt]);
-                               
-                               painter.clip(r);
-                               painter.renderText(r, string, flags);
+                               painter.renderText(rc, string, flags);
                                painter.clippop();
+
+                               // draw border
+                               if (bwidth)
+                               {
+                                       rc.setRect(x, y, width, height);
+                                       rc.moveBy(offset);
+                                       rc &= itemrect;
+                                       painter.clip(rc);
+                                       if (pborderColor)
+                                       {
+                                               int color = PyInt_AsLong(pborderColor);
+                                               painter.setForegroundColor(gRGB(color));
+                                       }
+                                       else if (pcolor)
+                                               style.setStyle(painter, selected ? eWindowStyle::styleListboxSelected : eWindowStyle::styleListboxNormal);
+
+                                       rc.setRect(x, y, width, bwidth);
+                                       rc.moveBy(offset);
+                                       painter.fill(rc);
+
+                                       rc.setRect(x, y+bwidth, bwidth, height-bwidth);
+                                       rc.moveBy(offset);
+                                       painter.fill(rc);
+
+                                       rc.setRect(x+bwidth, y+height-bwidth, width-bwidth, bwidth);
+                                       rc.moveBy(offset);
+                                       painter.fill(rc);
+
+                                       rc.setRect(x+width-bwidth, y+bwidth, bwidth, height-bwidth);
+                                       rc.moveBy(offset);
+                                       painter.fill(rc);
+
+                                       painter.clippop();
+                               }
+
                                break;
                        }
                        case TYPE_PROGRESS: // Progress
@@ -681,32 +637,32 @@ void eListboxPythonMultiContent::paint(gPainter &painter, eWindowStyle &style, c
                                int height = PyInt_AsLong(pheight);
                                int filled = PyInt_AsLong(pfnt);
 
-                               eRect r = eRect(x, y, width, height);
-                               r.moveBy(offset);
-                               r &= itemrect;
+                               eRect rc = eRect(x, y, width, height);
+                               rc.moveBy(offset);
+                               rc &= itemrect;
 
-                               painter.clip(r);
+                               painter.clip(rc);
                                int bwidth=2;  // borderwidth hardcoded yet
 
                                // border
-                               eRect rc = eRect(x, y, width, bwidth);
+                               rc.setRect(x, y, width, bwidth);
                                rc.moveBy(offset);
                                painter.fill(rc);
 
-                               rc = eRect(x, y+bwidth, bwidth, height-bwidth);
+                               rc.setRect(x, y+bwidth, bwidth, height-bwidth);
                                rc.moveBy(offset);
                                painter.fill(rc);
 
-                               rc = eRect(x+bwidth, y+height-bwidth, width-bwidth, bwidth);
+                               rc.setRect(x+bwidth, y+height-bwidth, width-bwidth, bwidth);
                                rc.moveBy(offset);
                                painter.fill(rc);
 
-                               rc = eRect(x+width-bwidth, y+bwidth, bwidth, height-bwidth);
+                               rc.setRect(x+width-bwidth, y+bwidth, bwidth, height-bwidth);
                                rc.moveBy(offset);
                                painter.fill(rc);
 
                                // progress
-                               rc = eRect(x+bwidth, y+bwidth, (width-bwidth*2) * filled / 100, height-bwidth*2);
+                               rc.setRect(x+bwidth, y+bwidth, (width-bwidth*2) * filled / 100, height-bwidth*2);
                                rc.moveBy(offset);
                                painter.fill(rc);
 
@@ -747,6 +703,9 @@ void eListboxPythonMultiContent::paint(gPainter &painter, eWindowStyle &style, c
                                eWarning("eListboxPythonMultiContent received unknown type (%d)", type);
                                goto error_out;
                        }
+                       
+                       if (pcolor || pborderColor || pfillColor)
+                               style.setStyle(painter, selected ? eWindowStyle::styleListboxSelected : eWindowStyle::styleListboxNormal);
                }
        }
        
@@ -754,9 +713,40 @@ void eListboxPythonMultiContent::paint(gPainter &painter, eWindowStyle &style, c
                style.drawFrame(painter, eRect(offset, m_itemsize), eWindowStyle::frameListboxEntry);
 
 error_out:
+       if (m_buildFunc && PyCallable_Check(m_buildFunc) && items)
+               Py_DECREF(items);
+
        painter.clippop();
 }
 
+void eListboxPythonMultiContent::setBuildFunc(ePyObject cb)
+{
+       if (m_buildFunc)
+               Py_DECREF(m_buildFunc);
+       m_buildFunc=cb;
+       if (cb)
+               Py_INCREF(m_buildFunc);
+}
+
+int eListboxPythonMultiContent::currentCursorSelectable()
+{
+       /* each list-entry is a list of tuples. if the first of these is none, it's not selectable */
+       if (m_list && cursorValid())
+       {
+               ePyObject item = PyList_GET_ITEM(m_list, m_cursor);
+               if (PyList_Check(item))
+               {
+                       item = PyList_GET_ITEM(item, 0);
+                       if (item != Py_None)
+                               return 1;
+               }
+               else if (m_buildFunc && PyCallable_Check(m_buildFunc))
+               // FIXME .. how we can detect non selectable entrys when we have a buildFunc callback
+                       return 1;
+       }
+       return 0;
+}
+
 void eListboxPythonMultiContent::setFont(int fnt, gFont *font)
 {
        if (font)
@@ -764,3 +754,10 @@ void eListboxPythonMultiContent::setFont(int fnt, gFont *font)
        else
                m_font.erase(fnt);
 }
+
+void eListboxPythonMultiContent::setItemHeight(int height)
+{
+       m_itemheight = height;
+       if (m_listbox)
+               m_listbox->setItemHeight(height);
+}