add support for writing python strings directly

[enigma2.git] / lib / base / console.cpp

diff --git a/lib/base/console.cpp b/lib/base/console.cpp
index c310bc9b07733a5ff27e70589a3a9e95f7da9f7d..a29772d8fac00a54d3453a67b2239f8fb9f5eea0 100644 (file)
--- a/lib/base/console.cpp
+++ b/lib/base/console.cpp
@@ -8,7 +8,7 @@
 #include <sys/types.h>
 #include <sys/wait.h>
 
-int bidirpipe(int pfd[], char *cmd , char *argv[])
+int bidirpipe(int pfd[], const char *cmd , const char * const argv[])
 {
        int pfdin[2];  /* from child to parent */
        int pfdout[2]; /* from parent to child */
@@ -37,7 +37,8 @@ int bidirpipe(int pfd[], char *cmd , char *argv[])
                for (unsigned int i=3; i < 90; ++i )
                        close(i);
 
-               execvp(cmd,argv);
+               execvp(cmd, (char * const *)argv); 
+                               /* the vfork will actually suspend the parent thread until execvp is called. thus it's ok to use the shared arg/cmdline pointers here. */
                _exit(0);
        }
        if (close(pfdout[0]) == -1 || close(pfdin[1]) == -1 || close(pfderr[1]) == -1)
@@ -80,11 +81,6 @@ static char *find_bracket(char ch)
 
 int eConsoleAppContainer::execute( const char *cmd )
 {
-       if (running())
-               return -1;
-       pid=-1;
-       killstate=0;
-
        int cnt=0, slen=strlen(cmd);
        char buf[slen+1];
        char *tmp=0, *argv[64], *path=buf, *cmds = buf;
@@ -109,42 +105,59 @@ int eConsoleAppContainer::execute( const char *cmd )
                return -2;
 
        tmp = strchr(path, ' ');
-       if (!tmp)
-               return -3;
-
-       *tmp = 0;
-       cmds = tmp+1;
+       if (tmp) {
+               *tmp = 0;
+               cmds = tmp+1;
+               while(*cmds && *cmds == ' ')
+                       ++cmds;
+       }
+       else
+               cmds = path+slen;
 
        memset(argv, 0, sizeof(argv));
        argv[cnt++] = path;
 
-       if (slen) {
-               char *argb=NULL;
-               char *it = find_bracket(*cmds);
+       if (*cmds) {
+               char *argb=NULL, *it=NULL;
                while ( (tmp = strchr(cmds, ' ')) ) {
+                       if (!it && *cmds && (it = find_bracket(*cmds)) )
+                               *cmds = 'X'; // replace open braket...
                        if (!argb) // not arg begin
                                argb = cmds;
                        if (it && *(tmp-1) == it[1]) {
+                               *argb = it[0]; // set old char for open braket
                                it = 0;
                        }
                        if (!it) { // end of arg
+                               *tmp = 0;
                                argv[cnt++] = argb;
                                argb=0; // reset arg begin
-                               it = find_bracket(*(tmp+1));
-                               *tmp = 0;
                        }
                        cmds = tmp+1;
+                       while (*cmds && *cmds == ' ')
+                               ++cmds;
                }
                argv[cnt++] = argb ? argb : cmds;
+               if (it)
+                   *argv[cnt-1] = it[0]; // set old char for open braket
        }
 
-       // get one read ,one write and the err pipe to the prog..
-
 //     int tmp=0;
 //     while(argv[tmp])
 //             eDebug("%d is %s", tmp, argv[tmp++]);
+       return execute(argv[0], argv);
+}
 
-       pid = bidirpipe(fd, argv[0], argv);
+int eConsoleAppContainer::execute(const char *cmdline, const char * const argv[])
+{
+       if (running())
+               return -1;
+
+       pid=-1;
+       killstate=0;
+
+       // get one read ,one write and the err pipe to the prog..
+       pid = bidirpipe(fd, cmdline, argv);
 
        if ( pid == -1 )
                return -3;
@@ -161,6 +174,28 @@ int eConsoleAppContainer::execute( const char *cmd )
        return 0;
 }
 
+int eConsoleAppContainer::execute( PyObject *cmdline, PyObject *args )
+{
+       if (!PyString_Check(cmdline))
+               return -1;
+       if (!PyList_Check(args))
+               return -1;
+       const char *argv[PyList_Size(args) + 1];
+       int i;
+       for (i = 0; i < PyList_Size(args); ++i)
+       {
+               PyObject *arg = PyList_GetItem(args, i); /* borrowed ref */
+               if (!arg)
+                       return -1;
+               if (!PyString_Check(arg))
+                       return -1;
+               argv[i] = PyString_AsString(arg); /* borrowed pointer */
+       }
+       argv[i] = 0;
+
+       return execute(PyString_AsString(cmdline), argv); /* borrowed pointer */
+}
+
 eConsoleAppContainer::~eConsoleAppContainer()
 {
        kill();
@@ -298,7 +333,18 @@ void eConsoleAppContainer::write( const char *data, int len )
        char *tmp = new char[len];
        memcpy(tmp, data, len);
        outbuf.push(queue_data(tmp,len));
-       out->start();
+       if (out)
+               out->start();
+}
+
+void eConsoleAppContainer::write( PyObject *data )
+{
+       char *buffer;
+       int length;
+       if (PyString_AsStringAndSize(data, &buffer, &length))
+               return;
+       if (buffer && length)
+               write(buffer, length);
 }
 
 void eConsoleAppContainer::readyWrite(int what)