stop();
context.addSocketNotifier(this);
- state=1;
+ state=2; // running but not in poll yet
}
void eSocketNotifier::stop()
{
int fd = sn->getFD();
ASSERT(notifiers.find(fd) == notifiers.end());
- ASSERT(new_notifiers.find(fd) == new_notifiers.end());
- new_notifiers[fd]=sn;
+ notifiers[fd]=sn;
}
void eMainloop::removeSocketNotifier(eSocketNotifier *sn)
{
- for (std::map<int,eSocketNotifier*>::iterator i = notifiers.find(sn->getFD());
- i != notifiers.end();
- ++i)
- if (i->second == sn)
- return notifiers.erase(i);
- for (std::map<int,eSocketNotifier*>::iterator i = new_notifiers.find(sn->getFD());
- i != new_notifiers.end();
- ++i)
- if (i->second == sn)
- return new_notifiers.erase(i);
+ int fd = sn->getFD();
+ std::map<int,eSocketNotifier*>::iterator i(notifiers.find(fd));
+ if (i != notifiers.end())
+ return notifiers.erase(i);
eFatal("removed socket notifier which is not present");
}
/* if current timer already passed, don't delay infinite. */
if (poll_timeout < 0)
poll_timeout = 0;
-
- /* convert us to ms */
- poll_timeout /= 1000;
+ else /* convert us to ms */
+ poll_timeout /= 1000;
}
if ((user_timeout > 0) && (poll_timeout > 0) && ((unsigned int)poll_timeout > user_timeout))
return_reason = 1;
}
- for (std::map<int, eSocketNotifier*>::iterator it(new_notifiers.begin()); it != new_notifiers.end();)
- {
- notifiers[it->first]=it->second;
- new_notifiers.erase(it++);
- }
-
int nativecount=notifiers.size(),
fdcount=nativecount,
ret=0;
int i=0;
for (; i < nativecount; ++i, ++it)
{
+ it->second->state = 1; // running and in poll
pfd[i].fd = it->first;
pfd[i].events = it->second->getRequested();
}
pfd[i++].events = PyInt_AsLong(val);
}
}
-
- ret = ::poll(pfd, fdcount, poll_timeout);
+
+ if (this == eApp)
+ Py_BEGIN_ALLOW_THREADS
+ ret = ::poll(pfd, fdcount, poll_timeout);
+ Py_END_ALLOW_THREADS
+ else
+ ret = ::poll(pfd, fdcount, poll_timeout);
+
/* ret > 0 means that there are some active poll entries. */
if (ret > 0)
{
int i=0;
return_reason = 0;
- for (; i < nativecount ; ++i)
+ for (; i < nativecount; ++i)
{
if (pfd[i].revents)
{
- int handled = 0;
it = notifiers.find(pfd[i].fd);
- if (it != notifiers.end())
+ if (it != notifiers.end()
+ && it->second->state == 1) // added and in poll
{
int req = it->second->getRequested();
- handled |= req;
if (pfd[i].revents & req)
- it->second->activate(pfd[i].revents);
+ it->second->activate(pfd[i].revents & req);
+ pfd[i].revents &= ~req;
}
- pfd[i].revents &= ~handled;
if (pfd[i].revents & (POLLERR|POLLHUP|POLLNVAL))
eDebug("poll: unhandled POLLERR/HUP/NVAL for fd %d(%d)", pfd[i].fd, pfd[i].revents);
}
Py_DECREF(it);
}
}
-
- ret = 1; /* poll did not timeout. */
- } else if (ret < 0)
+ }
+ else if (ret < 0)
{
/* when we got a signal, we get EINTR. */
if (errno != EINTR)
eDebug("poll made error (%m)");
else
- {
- return_reason = 2;
- ret = -1; /* don't assume the timeout has passed when we got a signal */
- }
+ return_reason = 2; /* don't assume the timeout has passed when we got a signal */
}
/* when we not processed anything, check timers. */
if (ret || m_now_is_invalid)
gettimeofday(&now, 0);
- else
+ else // poll timeoutet
now += poll_timeout;
/* process all timers which are ready. first remove them out of the list. */
int eMainloop::iterate(unsigned int user_timeout, PyObject **res, ePyObject dict)
{
int ret = 0;
-
+
timeval user_timer;
gettimeofday(&user_timer, 0);
user_timer += user_timeout;
m_interrupt_requested = 0;
return 0;
}
- if (app_quit_now) return -1;
- timeval now, timeout;
- gettimeofday(&now, 0);
- timeout = user_timer - now;
-
- if (user_timeout && (user_timer <= now))
- return 0;
-
+
+ if (app_quit_now)
+ return -1;
+
int to = 0;
if (user_timeout)
+ {
+ timeval now, timeout;
+ gettimeofday(&now, 0);
+ if (user_timer<=now) // timeout
+ return 0;
+ timeout = user_timer - now;
to = timeout.tv_sec * 1000 + timeout.tv_usec / 1000;
-
+ }
ret = processOneEvent(to, res, dict);
- if (res && *res)
- return ret;
- } while (ret == 0);
+ } while ( !ret && !(res && *res) );
return ret;
}
PyObject *res=0;
if (app_quit_now)
- {
- Py_INCREF(Py_None);
- return Py_None;
- }
+ Py_RETURN_NONE;
int user_timeout = (timeout == Py_None) ? 0 : PyInt_AsLong(timeout);
iterate(user_timeout, &res, dict);
- ePyObject ret(res);
-
- if (!ret) /* return empty list on timeout */
- return PyList_New(0);
-
- return ret;
+ if (res)
+ return res;
+
+ return PyList_New(0); /* return empty list on timeout */
}
void eMainloop::interruptPoll()