X-Git-Url: https://git.cweiske.de/enigma2.git/blobdiff_plain/3458b59694ee3659c2afdd3e7e48a2e087f1102f..65d256dab9e29d50ab02d1d5bd6319ab8a50dc82:/lib/gui/elistbox.cpp diff --git a/lib/gui/elistbox.cpp b/lib/gui/elistbox.cpp index d4c653fe..e8a0dada 100644 --- a/lib/gui/elistbox.cpp +++ b/lib/gui/elistbox.cpp @@ -54,16 +54,10 @@ void eListbox::setWrapAround(bool state) void eListbox::setContent(iListboxContent *content) { - int oldsel = m_selected; m_content = content; if (content) m_content->setListbox(this); entryReset(); - /* if oldsel != m_selected, selectionChanged was already - emitted in entryReset. we want it in any case, so otherwise, - emit it now. */ - if (oldsel == m_selected) - /* emit */ selectionChanged(); } bool eListbox::atBegin() @@ -285,7 +279,7 @@ void eListbox::updateScrollBar() if ((pages*m_items_per_page) < entries) ++pages; int start=(m_top*100)/(pages*m_items_per_page); - int vis=(m_items_per_page*100)/(pages*m_items_per_page); + int vis=(m_items_per_page*100+pages*m_items_per_page-1)/(pages*m_items_per_page); if (vis < 3) vis=3; m_scrollbar->setStartEnd(start,start+vis); @@ -331,7 +325,7 @@ int eListbox::event(int event, void *data, void *data2) m_content->paint(painter, *style, ePoint(0, y), m_selected == m_content->cursorGet() && m_content->size() && m_selection_enabled); /* (we could clip with entry_clip_rect, but - this shouldn't change the behaviour of any + this shouldn't change the behavior of any well behaving content, so it would just degrade performance without any gain.) */ @@ -457,6 +451,7 @@ void eListbox::entryReset(bool selectionHome) { m_content_changed = true; m_prev_scrollbar_page = -1; + int oldsel; if (selectionHome) { @@ -473,10 +468,15 @@ void eListbox::entryReset(bool selectionHome) else m_selected = 0; m_content->cursorSet(m_selected); - selectionChanged(); } + oldsel = m_selected; moveSelection(justCheck); + /* if oldsel != m_selected, selectionChanged was already + emitted in moveSelection. we want it in any case, so otherwise, + emit it now. */ + if (oldsel == m_selected) + /* emit */ selectionChanged(); invalidate(); }