| Age | Commit message (Collapse) | Author |
|
* Jumping between marks in the movie, with "<" and ">", doesn't work
well when there are cut marks in the movie. Especially jumping
backwards will fail if there is a mark in a cut out region that is
to be jumped over. (InfoBarGenerics.py, chunks 3 and 4)
* Now when rewind works at all platforms also at low speeds, the
rewind speeds x2 and x4 should be added again to the
default. (UsageConfig.py, chunk 1)
* Cleanup some obsolete code: SeekBackHack and non-smooth
winding. None of these can be used anymore, but remnants were left
in the code and in the configuration alternatives. It is high time
to clean these out. (setup.xml, UsageConfig.py chunk 2,
InfoBarGenerics.py chunks 1 and 2, DVDPlayer)
* In the position gauge of the movie player, marks in the movie are
shown as red dots. Long time ago the last position was also shown as
a red dot, which was bad because it was confused with the marks, so
it was removed. However, jumping between marks in the movie with "<"
and ">" also stops at the last position, which is useful e.g. if you
don't automatically start playing from the last position. The code
below adds the last position back to the position gauge as a green dot,
to distinguish it from the red ones. (epositiongauge.cpp)
refs bug #570
|
|
* My previous code for "slow rewind" (aka "SeekBackHack") is not
required any more. Indeed, since the change in "decoder states"
some time ago my code stopped working and is now only destructively
interfering with the new winding approach, effectively ruining the
speed accuracy for slow rewind. Similarly, the "non-smooth winding"
code ruins the accuracy for high winding speeds. The patch below
removes the "SeekBackHack", and temporarily disables the
"non-smooth winding" code until we know whether the decoder states
will allow simultaneous repeat and skip rates
again. (InfoBarGenerics.py)
* Due to a bug in 'eDVBTSTools::findNextPicture', rewind was always
at the required speed minus one. (The frame just played was counted
as one when skipping backwards.) Fixed below. (tstools.cpp)
* A piece of code to apparently increase precision in seeking, by
always aligning to an i-frame start, had exactly the opposite
effect: GOP single-stepping fails completely on DM7025 and gets
highly unreliable on DM800. The piece of code is removed.
(It destructively interferes with previous code by me to hit frames
somewhat before the GOP start. As an alternative, my previous code
can be removed instead, and the currently removed piece of code
adjusted to work. But then it has to be done differently on the two
platforms.) (dvb.cpp)
* By some reason eDVBVideo::getPTS only returns even numbers on DM800
even when it should be odd. This ruins GOP single stepping in 50%
of the cases. This is easy to compensate for by adding a margin of
1 in getAccessPoint. (pvrparse.cpp)
* After the above, when GOP single-stepping works reliable on both
platforms and on SD/HD, the correct step lengths can be
used. (InfoBarGenerics.py)
|
|
- this allows finding iframes for fast forward/reverse more easily
- when in fast forward, strictly just output good (=complete iframes) data (this might break dm7025, we will fix this later)
- draw smaller, fixed-size bar in position gauge
|
|
Conflicts:
lib/dvb/decoder.cpp
|
|
|
|
Conflicts:
lib/dvb/sec.cpp
lib/python/Components/Network.py
lib/python/Components/Playlist.py
lib/python/Plugins/Extensions/DVDBurn/Process.py
lib/python/Plugins/Extensions/MediaPlayer/plugin.py
lib/python/Screens/TimerEdit.py
po/lt.po
po/nl.po
po/tr.po
|
|
|
|
|
|
* Undo "sparse-AP-fix"
At March 25 a patch was checked in that makes sure that AP:s closer
than half a second from each other are filtered away. I don't know
the exact purpose of this fix, but I don't think it is a good idea:
Besides being the cause of bugs 4 and 5 above, all seek operations
are based on the AP:s, and it is a pity to cripple the precision
here. And for example, when cutting movies it is important to be
able to reach the right GOP boundary. (And the next fix relies on
all boundaries being available.) (If you wonder, bug 5 was caused by
a destructive interaction of this with the discontinuity handling.)
* Hit GOP:s somewhat before GOP start
It turns out that if you jump exactly to the GOP start, then that
GOP is nevertheless skipped and playback starts from the GOP
thereafter. However, if you jump to (at least) one frame before the
GOP start, playback starts from that GOP. I don't know if this is a
bug in the driver or elsewhere, but the best I can do is this
workaround: Hit the GOP by jumping to half a GOP length before the
GOP start. (By scanning the ts file it is of course possible to find
the exact frame boundaries, but why bother since anywhere between
the previous GOP start and the previous frame start will do.)
Similarly, to show the first frame of a GOP, a few more frames must
be included. Therefore, add half a GOP at the end of each source
span.
* Jump over discontinuities during AP relative seek
The above two fixes together *almost* take care of bugs 1 and 2
above. Now seekRelative(1) moves one forward and seekRelative(-1) one
backwards. However, at discontinuities they may get stuck. This is
remedied by an extra if statement to check for discontinuities when
stepping throught the AP:s in AP relative seek.
* Stop after last source span
In the function eDVBChannel::getNextSourceSpan there was no code to
take care of the case when the seeked-to point is after the last
source span. Currently it just goes on until the movie ends. I have
added code for this, which takes care of bug 3, and as a fortunate
bonus effect bug 6 too. (But please check my code here, I hope I can
use current_offset the way I do, and return 0 size when it should
stop.)
|
|
|
|
|
|
things a bit
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|