From 39708e44b6f6fd25fd3e02ae119351bdebadbfb5 Mon Sep 17 00:00:00 2001 From: Felix Domke Date: Fri, 5 May 2006 17:56:41 +0000 Subject: [PATCH] use constants instead of strings, don't restart main service --- lib/python/Screens/InfoBarGenerics.py | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/lib/python/Screens/InfoBarGenerics.py b/lib/python/Screens/InfoBarGenerics.py index a5938222..c7076225 100644 --- a/lib/python/Screens/InfoBarGenerics.py +++ b/lib/python/Screens/InfoBarGenerics.py @@ -1015,20 +1015,24 @@ class InfoBarExtensions: { "extensions": (self.extensions, "Extensions..."), }) - + + PIPON = 0 + PIPOFF = 1 + MOVEPIP = 2 + def extensions(self): list = [] if self.pipshown == False: - list.append((_("Activate Picture in Picture"), "pipon")) + list.append((_("Activate Picture in Picture"), self.PIPON)) elif self.pipshown == True: - list.append((_("Disable Picture in Picture"), "pipoff")) - list.append((_("Move Picture in Picture"), "movepip")) + list.append((_("Disable Picture in Picture"), self.PIPOFF)) + list.append((_("Move Picture in Picture"), self.MOVEPIP)) self.session.openWithCallback(self.extensionCallback, ChoiceBox, title=_("Please choose an extension..."), list = list) def extensionCallback(self, answer): if answer is not None: - if answer[1] == "pipon": - self.session.nav.stopService() + if answer[1] == self.PIPON: +# self.session.nav.stopService() self.pip = self.session.instantiateDialog(PictureInPicture) #self.pip.show() @@ -1041,12 +1045,12 @@ class InfoBarExtensions: self.pipservice = None del self.pip self.session.nav.playService(newservice) - elif answer[1] == "pipoff": + elif answer[1] == self.PIPOFF: #self.pip.hide() self.pipservice = None del self.pip self.pipshown = False - elif answer[1] == "movepip": + elif answer[1] == self.MOVEPIP: self.session.open(PiPSetup, pip = self.pip) from RecordTimer import parseEvent -- 2.30.2