From 999ddaa2a3953f5e16549483cd8deb021685fc5b Mon Sep 17 00:00:00 2001 From: Felix Domke Date: Fri, 5 Jan 2007 15:12:38 +0000 Subject: [PATCH] fix refcounts --- lib/dvb/pmt.cpp | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/lib/dvb/pmt.cpp b/lib/dvb/pmt.cpp index 1b1455e4..7f560c8e 100644 --- a/lib/dvb/pmt.cpp +++ b/lib/dvb/pmt.cpp @@ -865,36 +865,42 @@ static PyObject *createTuple(int pid, const char *type) return r; } +static inline PyList_AppendSteal(PyObject *list, PyObject *item) +{ + PyList_Append(list, item); + Py_DECREF(item); +} + PyObject *eDVBServicePMTHandler::program::createPythonObject() { PyObject *r = PyDict_New(); PyObject *l = PyList_New(0); - PyList_Append(l, createTuple(0, "pat")); + PyList_AppendSteal(l, createTuple(0, "pat")); if (pmtPid != -1) - PyList_Append(l, createTuple(pmtPid, "pmt")); + PyList_AppendSteal(l, createTuple(pmtPid, "pmt")); for (std::vector::const_iterator i(videoStreams.begin()); i != videoStreams.end(); ++i) - PyList_Append(l, createTuple(i->pid, "video")); + PyList_AppendSteal(l, createTuple(i->pid, "video")); for (std::vector::const_iterator i(audioStreams.begin()); i != audioStreams.end(); ++i) - PyList_Append(l, createTuple(i->pid, "audio")); + PyList_AppendSteal(l, createTuple(i->pid, "audio")); for (std::vector::const_iterator i(subtitleStreams.begin()); i != subtitleStreams.end(); ++i) - PyList_Append(l, createTuple(i->pid, "subtitle")); + PyList_AppendSteal(l, createTuple(i->pid, "subtitle")); - PyList_Append(l, createTuple(pcrPid, "pcr")); + PyList_AppendSteal(l, createTuple(pcrPid, "pcr")); if (textPid != -1) - PyList_Append(l, createTuple(textPid, "text")); + PyList_AppendSteal(l, createTuple(textPid, "text")); PyDict_SetItemString(r, "pids", l); return r; -- 2.30.2