X-Git-Url: https://git.cweiske.de/grauphel.git/blobdiff_plain/e74217a7bbd58cf76963c15c73221669e1153510..1a5b0cd1539c149d18db4e40f16c56654cace898:/controller/guicontroller.php diff --git a/controller/guicontroller.php b/controller/guicontroller.php index b09ef4a..d48296d 100644 --- a/controller/guicontroller.php +++ b/controller/guicontroller.php @@ -96,7 +96,9 @@ class GuiController extends Controller $note = $this->getNotes()->load($guid, false); if ($note === null) { - return new ErrorResponse('Note does not exist'); + $res = new ErrorResponse('Note does not exist'); + $res->setStatus(\OCP\AppFramework\Http::STATUS_NOT_FOUND); + return $res; } $converter = new \OCA\Grauphel\Converter\Html(); @@ -120,11 +122,17 @@ class GuiController extends Controller 'note' => $note, 'note-content' => $contentHtml, 'links' => array( + 'html' => $this->urlGen->linkToRoute( + 'grauphel.notes.html', array('guid' => $guid) + ), 'json' => $this->urlGen->linkToRoute( 'grauphel.api.note', array( 'guid' => $guid, 'username' => $this->user->getUid() ) ), + 'text' => $this->urlGen->linkToRoute( + 'grauphel.notes.text', array('guid' => $guid) + ), 'xml' => $this->urlGen->linkToRoute( 'grauphel.notes.xml', array('guid' => $guid) ), @@ -160,6 +168,7 @@ class GuiController extends Controller */ public function tag($rawtag) { + $rawtag = $this->unescapeTagFromUrl($rawtag); $notes = $this->getNotes()->loadNotesOverview(null, $rawtag, true); usort( $notes, @@ -280,7 +289,8 @@ class GuiController extends Controller 'name' => $name, 'id' => $rawtag, 'href' => $this->urlGen->linkToRoute( - 'grauphel.gui.tag', array('rawtag' => $rawtag) + 'grauphel.gui.tag', + array('rawtag' => $this->escapeTagForUrl($rawtag)) ), 'selected' => $rawtag == $selectedRawtag, ); @@ -344,5 +354,15 @@ class GuiController extends Controller } return false; } + + protected function escapeTagForUrl($rawtag) + { + return str_replace('/', '%2F', $rawtag); + } + + protected function unescapeTagFromUrl($rawtag) + { + return str_replace('%2F', '/', $rawtag); + } } ?>