summaryrefslogtreecommitdiff
path: root/controller/oauthcontroller.php
diff options
context:
space:
mode:
authorChristian Weiske <cweiske@cweiske.de>2014-09-26 11:08:05 +0200
committerChristian Weiske <cweiske@cweiske.de>2014-09-26 11:08:05 +0200
commit13b040be9828997d4352f05c8464b86f6effd9f9 (patch)
treea9de9ed725fc6552d819626070f6a6883d66b17c /controller/oauthcontroller.php
parentf1db8976591ace3a1879ddd1217ed22bdca82dc2 (diff)
downloadgrauphel-13b040be9828997d4352f05c8464b86f6effd9f9.tar.gz
grauphel-13b040be9828997d4352f05c8464b86f6effd9f9.zip
Fix oauth problem with tomdroid.
Tomdroid[0] uses signpost[1] as oauth library. This lib detected our server as OAuth 1.0 and not 1.0a because callback_confirmed was "TRUE" instead of "true". OAuth 1.0 does not have the verifier parameter, so it was ignored and not sent to our server. The OAuth RFC 5849 specifies in section 2.1: oauth_callback_confirmed MUST be present and set to "true". TRUE is not true, so we failed to implement the spec correctly. [0] https://launchpad.net/tomdroid [1] https://github.com/mttkay/signpost
Diffstat (limited to 'controller/oauthcontroller.php')
-rw-r--r--controller/oauthcontroller.php2
1 files changed, 1 insertions, 1 deletions
diff --git a/controller/oauthcontroller.php b/controller/oauthcontroller.php
index 29198bc..8672927 100644
--- a/controller/oauthcontroller.php
+++ b/controller/oauthcontroller.php
@@ -251,7 +251,7 @@ class OauthController extends Controller
array(
'oauth_token' => $token->tokenKey,
'oauth_token_secret' => $token->secret,
- 'oauth_callback_confirmed' => 'TRUE'
+ 'oauth_callback_confirmed' => 'true'
)
);
} catch (OAuthException $e) {