From: Christian Weiske <cweiske@cweiske.de>
Date: Fri, 14 Aug 2015 05:47:15 +0000 (+0200)
Subject: Fix #22 and #24: Escape slashes in tags in URLs
X-Git-Tag: v0.6.0~5
X-Git-Url: https://git.cweiske.de/grauphel.git/commitdiff_plain/ba4f1f02ea2f99eb2be367530f28e0146fa303f7?hp=d776c4c77ddb59cb571f23bf4ef042bd0a246751

Fix #22 and #24: Escape slashes in tags in URLs

References:
- https://github.com/cweiske/grauphel/issues/22
- https://github.com/cweiske/grauphel/issues/24
---

diff --git a/controller/guicontroller.php b/controller/guicontroller.php
index 29dd03f..d48296d 100644
--- a/controller/guicontroller.php
+++ b/controller/guicontroller.php
@@ -168,6 +168,7 @@ class GuiController extends Controller
      */
     public function tag($rawtag)
     {
+        $rawtag = $this->unescapeTagFromUrl($rawtag);
         $notes = $this->getNotes()->loadNotesOverview(null, $rawtag, true);
         usort(
             $notes,
@@ -288,7 +289,8 @@ class GuiController extends Controller
                     'name' => $name,
                     'id'   => $rawtag,
                     'href' => $this->urlGen->linkToRoute(
-                        'grauphel.gui.tag', array('rawtag' => $rawtag)
+                        'grauphel.gui.tag',
+                        array('rawtag' => $this->escapeTagForUrl($rawtag))
                     ),
                     'selected' => $rawtag == $selectedRawtag,
                 );
@@ -352,5 +354,15 @@ class GuiController extends Controller
         }
         return false;
     }
+
+    protected function escapeTagForUrl($rawtag)
+    {
+        return str_replace('/', '%2F', $rawtag);
+    }
+
+    protected function unescapeTagFromUrl($rawtag)
+    {
+        return str_replace('%2F', '/', $rawtag);
+    }
 }
 ?>