From ba4f1f02ea2f99eb2be367530f28e0146fa303f7 Mon Sep 17 00:00:00 2001 From: Christian Weiske Date: Fri, 14 Aug 2015 07:47:15 +0200 Subject: [PATCH] Fix #22 and #24: Escape slashes in tags in URLs References: - https://github.com/cweiske/grauphel/issues/22 - https://github.com/cweiske/grauphel/issues/24 --- controller/guicontroller.php | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/controller/guicontroller.php b/controller/guicontroller.php index 29dd03f..d48296d 100644 --- a/controller/guicontroller.php +++ b/controller/guicontroller.php @@ -168,6 +168,7 @@ class GuiController extends Controller */ public function tag($rawtag) { + $rawtag = $this->unescapeTagFromUrl($rawtag); $notes = $this->getNotes()->loadNotesOverview(null, $rawtag, true); usort( $notes, @@ -288,7 +289,8 @@ class GuiController extends Controller 'name' => $name, 'id' => $rawtag, 'href' => $this->urlGen->linkToRoute( - 'grauphel.gui.tag', array('rawtag' => $rawtag) + 'grauphel.gui.tag', + array('rawtag' => $this->escapeTagForUrl($rawtag)) ), 'selected' => $rawtag == $selectedRawtag, ); @@ -352,5 +354,15 @@ class GuiController extends Controller } return false; } + + protected function escapeTagForUrl($rawtag) + { + return str_replace('/', '%2F', $rawtag); + } + + protected function unescapeTagFromUrl($rawtag) + { + return str_replace('%2F', '/', $rawtag); + } } ?> -- 2.30.2