From e19fc06310e26dab3ec372fb01676a802fc02234 Mon Sep 17 00:00:00 2001 From: Christian Weiske Date: Tue, 17 Mar 2015 19:53:17 +0100 Subject: [PATCH] Send 404 if a note cannot be found --- controller/guicontroller.php | 4 +++- controller/notescontroller.php | 5 +++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/controller/guicontroller.php b/controller/guicontroller.php index b09ef4a..8ebea8c 100644 --- a/controller/guicontroller.php +++ b/controller/guicontroller.php @@ -96,7 +96,9 @@ class GuiController extends Controller $note = $this->getNotes()->load($guid, false); if ($note === null) { - return new ErrorResponse('Note does not exist'); + $res = new ErrorResponse('Note does not exist'); + $res->setStatus(\OCP\AppFramework\Http::STATUS_NOT_FOUND); + return $res; } $converter = new \OCA\Grauphel\Converter\Html(); diff --git a/controller/notescontroller.php b/controller/notescontroller.php index 02bfc93..5618bcb 100644 --- a/controller/notescontroller.php +++ b/controller/notescontroller.php @@ -58,6 +58,11 @@ class NotesController extends Controller public function xml($guid) { $note = $this->getNotes()->load($guid, false); + if ($note === null) { + $res = new ErrorResponse('Note does not exist'); + $res->setStatus(\OCP\AppFramework\Http::STATUS_NOT_FOUND); + return $res; + } $xw = new \XMLWriter(); $xw->openMemory(); -- 2.30.2