Avoid leaking file descriptor when looking for binary files

[phorkie.git] / src / phorkie / File.php

diff --git a/src/phorkie/File.php b/src/phorkie/File.php
index 2afda4c89fc8b2514ebef68a41d5ba3e1bc499aa..97ae47e934e14d974ab062d0882ec478a603bfd8 100644 (file)
--- a/src/phorkie/File.php
+++ b/src/phorkie/File.php
@@ -84,22 +84,8 @@ class File
 
     public function getRenderedContent(Tool_Result $res = null)
     {
-        $ext   = $this->getExt();
-        $class = '\\phorkie\\Renderer_Unknown';
-
-        if (isset($GLOBALS['phorkie']['languages'][$ext]['renderer'])) {
-            $class = $GLOBALS['phorkie']['languages'][$ext]['renderer'];
-        } else if ($this->isText()) {
-            $class = '\\phorkie\\Renderer_Geshi';
-        } else if (isset($GLOBALS['phorkie']['languages'][$ext]['mime'])) {
-            $type = $GLOBALS['phorkie']['languages'][$ext]['mime'];
-            if (substr($type, 0, 6) == 'image/') {
-                $class = '\\phorkie\\Renderer_Image';
-            }
-        }
-
-        $rend = new $class();
-        return $rend->toHtml($this, $res);
+        $cache = new Renderer_Cache();
+        return $cache->toHtml($this, $res);
     }
 
     /**
@@ -140,15 +126,21 @@ class File
     }
 
     /**
-     * @return string Mime type of file
+     * @return string Mime type of file, NULL if no type detected
      */
     public function getMimeType()
     {
         $ext = $this->getExt();
-        if (!isset($GLOBALS['phorkie']['languages'][$ext])) {
-            return null;
+        if (isset($GLOBALS['phorkie']['languages'][$ext])) {
+            return $GLOBALS['phorkie']['languages'][$ext]['mime'];
         }
-        return $GLOBALS['phorkie']['languages'][$ext]['mime'];
+
+        $mte = new \MIME_Type_Extension();
+        $type = $mte->getMIMEType($this->getFilename());
+        if (!\PEAR::isError($type)) {
+            return $type;
+        }
+        return null;
     }
 
     /**
@@ -173,22 +165,56 @@ class File
     {
         $ext = $this->getExt();
         if ($ext == '') {
-            //no file extension? then consider the size
-            $size = filesize($this->getFullPath());
-            //files <= 4kiB are considered to be text
-            return $size <= 4096;
+            return $this->isNonBinary();
         }
 
-        if (!isset($GLOBALS['phorkie']['languages'][$ext]['mime'])) {
-            return false;
+        $type = $this->getMimeType();
+        if ($type === null) {
+            return $this->isNonBinary();
         }
-
-        $type = $GLOBALS['phorkie']['languages'][$ext]['mime'];
         return substr($type, 0, 5) === 'text/'
             || $type == 'application/javascript'
             || substr($type, -4) == '+xml'
             || substr($type, -5) == '+json';
     }
+
+    /**
+     * Look at the file's bytes and guess if it's binary or not.
+     *
+     * @return boolean True if it's most likely plain text
+     */
+    public function isNonBinary()
+    {
+        $fp = fopen($this->getFullPath(), 'r');
+        if (!$fp) {
+            return false;
+        }
+
+        //When multibyte extension is not installed,
+        // we only allow files with ASCII characters.
+        // Files with UTF-8 characters will not be detected as text.
+        $hasMb = function_exists('mb_detect_encoding');
+
+        $pos = 0;
+        $data = '';
+        while (false !== ($char = fgetc($fp)) && ++$pos < 100) {
+            $data .= $char;
+            if (!$hasMb && ord($char) > 128) {
+                fclose($fp);
+                return false;
+            }
+        }
+        fclose($fp);
+
+        if (!$hasMb) {
+            return true;
+        }
+
+        if (mb_detect_encoding($data) === false) {
+            return false;
+        }
+        return true;
+    }
 }
 
 ?>