From: Christophe Coevoet <stof@notk.org>
Date: Fri, 6 Nov 2015 09:23:40 +0000 (+0100)
Subject: Avoid leaking file descriptor when looking for binary files
X-Git-Tag: v0.8.0~11
X-Git-Url: https://git.cweiske.de/phorkie.git/commitdiff_plain/0f0ad04504e60d8f410472232480eb1fd9332814

Avoid leaking file descriptor when looking for binary files
---

diff --git a/src/phorkie/File.php b/src/phorkie/File.php
index cf5daae..97ae47e 100644
--- a/src/phorkie/File.php
+++ b/src/phorkie/File.php
@@ -200,9 +200,12 @@ class File
         while (false !== ($char = fgetc($fp)) && ++$pos < 100) {
             $data .= $char;
             if (!$hasMb && ord($char) > 128) {
+                fclose($fp);
                 return false;
             }
         }
+        fclose($fp);
+
         if (!$hasMb) {
             return true;
         }