From: Christian Weiske Date: Wed, 24 Oct 2012 13:16:24 +0000 (+0200) Subject: show proper error message on remote forking X-Git-Tag: v0.4.0~105 X-Git-Url: https://git.cweiske.de/phorkie.git/commitdiff_plain/860aaa0c3f990fd888bb779f60d24b39d8adaae9 show proper error message on remote forking --- diff --git a/src/phorkie/ForkRemote.php b/src/phorkie/ForkRemote.php index 78c3caa..7f6129d 100644 --- a/src/phorkie/ForkRemote.php +++ b/src/phorkie/ForkRemote.php @@ -3,6 +3,11 @@ namespace phorkie; class ForkRemote { + /** + * Contains error message when parse() failed + */ + public $error; + protected $url; /** @@ -90,7 +95,12 @@ class ForkRemote } } - return $count > 0; + if ($count > 0) { + return true; + } + + $this->error = 'No git:// clone URL found'; + return false; } /** diff --git a/www/fork-remote.php b/www/fork-remote.php index 0567748..5d4a4ee 100644 --- a/www/fork-remote.php +++ b/www/fork-remote.php @@ -12,7 +12,7 @@ if (isset($_POST['remote_url'])) { $fr = new ForkRemote($_POST['remote_url']); if (false === $fr->parse()) { //no url found - $error = 'No git:// clone URL found'; + $error = $fr->error; } else if (false !== ($gitUrl = $fr->getUniqueGitUrl())) { if (isset($_POST['orig_url'])) { $fr->setUrl($_POST['orig_url']);