Send 404 if a note cannot be found

diff --git a/controller/guicontroller.php b/controller/guicontroller.php
index b09ef4a2baf9c3fdf45b164653acb935b9ba94b8..8ebea8c58f5b8900e4dfeb7a14cc97ed1e079f13 100644 (file)
--- a/controller/guicontroller.php
+++ b/controller/guicontroller.php
@@ -96,7 +96,9 @@ class GuiController extends Controller
 
         $note = $this->getNotes()->load($guid, false);
         if ($note === null) {
-            return new ErrorResponse('Note does not exist');
+            $res = new ErrorResponse('Note does not exist');
+            $res->setStatus(\OCP\AppFramework\Http::STATUS_NOT_FOUND);
+            return $res;
         }
 
         $converter = new \OCA\Grauphel\Converter\Html();

diff --git a/controller/notescontroller.php b/controller/notescontroller.php
index 02bfc93eae1fc7f0fb16f7a2b01494582a643e1d..5618bcbb04b33473e9be78a88cb36e4abe4dc4bf 100644 (file)
--- a/controller/notescontroller.php
+++ b/controller/notescontroller.php
@@ -58,6 +58,11 @@ class NotesController extends Controller
     public function xml($guid)
     {
         $note = $this->getNotes()->load($guid, false);
+        if ($note === null) {
+            $res = new ErrorResponse('Note does not exist');
+            $res->setStatus(\OCP\AppFramework\Http::STATUS_NOT_FOUND);
+            return $res;
+        }
 
         $xw = new \XMLWriter();
         $xw->openMemory();