} else {
error('Authorization HTTP header missing');
}
- list($bearer, $token) = explode(' ', $auth, 2);
+
+ $parts = explode(' ', $auth, 2);
+ if (count($parts) != 2) {
+ error('Authorization header must container "Bearer" and the token');
+ }
+
+ list($bearer, $token) = $parts;
if ($bearer !== 'Bearer') {
error('Authorization header must start with "Bearer"');
}
} else if ($_SERVER['REQUEST_METHOD'] == 'POST') {
//generate token
- $me = verifyUrlParameter($_POST, 'me');
+ //we ignore the "me" parameter; it's for proxies only
+ // see https://github.com/cweiske/anoweco/issues/3
$redirect_uri = verifyUrlParameter($_POST, 'redirect_uri');
$client_id = verifyUrlParameter($_POST, 'client_id');
$code = verifyParameter($_POST, 'code');//auth token
parse_str(base64_decode($code), $codeParts);
$emoji = verifyParameter($codeParts, 'emoji');
$signature = verifyParameter($codeParts, 'signature');
- $codeMe = verifyUrlParameter($codeParts, 'me');
+ $me = verifyUrlParameter($codeParts, 'me');
if ($emoji != '\360\237\222\251') {
error('Auth token: Dog poo missing');
}
if ($signature != 'FIXME') {
error('Auth token: Invalid signature');
}
- if ($me !== $codeMe) {
- error('Auth token is not valid for the given "me"');
- }
//FIXME: check if state are set
//FIXME: check auth endpoint if parameters are valid