git.cweiske.de
/
phorkie.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
fix crash when renaming file
[phorkie.git]
/
src
/
phorkie
/
Repository
/
Post.php
diff --git
a/src/phorkie/Repository/Post.php
b/src/phorkie/Repository/Post.php
index b181b5a2b198ef6e52ebe83856c338ec86598b90..7a373aaf9005e65343c831700db81d2ef327403f 100644
(file)
--- a/
src/phorkie/Repository/Post.php
+++ b/
src/phorkie/Repository/Post.php
@@
-5,6
+5,16
@@
class Repository_Post
{
public $repo;
{
public $repo;
+ /**
+ * When a new file is created during processing, its name
+ * is stored here for later use.
+ *
+ * @var string
+ */
+ public $newfileName;
+
+
+
public function __construct(Repository $repo = null)
{
$this->repo = $repo;
public function __construct(Repository $repo = null)
{
$this->repo = $repo;
@@
-48,8
+58,8
@@
class Repository_Post
continue;
}
continue;
}
- $orignalName = Tools::sanitizeFilename($arFile['original_name']);
- $name = Tools::sanitizeFilename($arFile['name']);
+ $orig
i
nalName = Tools::sanitizeFilename($arFile['original_name']);
+ $name
= Tools::sanitizeFilename($arFile['name']);
if ($arFile['type'] == '_auto_') {
//FIXME: upload
if ($arFile['type'] == '_auto_') {
//FIXME: upload
@@
-58,7
+68,9
@@
class Repository_Post
if ($name == '') {
if ($bUpload) {
if ($name == '') {
if ($bUpload) {
- $name = Tools::sanitizeFilename($_FILES['files']['name'][$num]['upload']);
+ $name = Tools::sanitizeFilename(
+ $_FILES['files']['name'][$num]['upload']
+ );
} else {
$name = $this->getNextNumberedFile('phork')
. '.' . $arFile['type'];
} else {
$name = $this->getNextNumberedFile('phork')
. '.' . $arFile['type'];
@@
-67,34
+79,38
@@
class Repository_Post
$bNew = false;
$bDelete = false;
$bNew = false;
$bDelete = false;
- if (!isset($orig
nalName) || $orig
nalName == '') {
+ if (!isset($orig
inalName) || $origi
nalName == '') {
//new file
$bNew = true;
if (strpos($name, '.') === false) {
//automatically append file extension if none is there
$name .= '.' . $arFile['type'];
}
//new file
$bNew = true;
if (strpos($name, '.') === false) {
//automatically append file extension if none is there
$name .= '.' . $arFile['type'];
}
- } else if (!$this->repo->hasFile($orignalName)) {
+ $this->newfileName = $name;
+ } else if (!$this->repo->hasFile($originalName)) {
//unknown file
//FIXME: Show error message
continue;
} else if (isset($arFile['delete']) && $arFile['delete'] == 1) {
$bDelete = true;
//unknown file
//FIXME: Show error message
continue;
} else if (isset($arFile['delete']) && $arFile['delete'] == 1) {
$bDelete = true;
- } else if ($orignalName != $name) {
+ } else if ($orig
i
nalName != $name) {
if (strpos($name, '/') === false) {
//ignore names with a slash in it, would be new directory
//FIXME: what to do with overwrites?
$vc->getCommand('mv')
if (strpos($name, '/') === false) {
//ignore names with a slash in it, would be new directory
//FIXME: what to do with overwrites?
$vc->getCommand('mv')
- ->addArgument($orignalName)
+ ->addArgument($orig
i
nalName)
->addArgument($name)
->execute();
$bCommit = true;
} else {
->addArgument($name)
->execute();
$bCommit = true;
} else {
- $name = $orignalName;
+ $name = $orig
i
nalName;
}
}
$file = $this->repo->getFileByName($name, false);
}
}
$file = $this->repo->getFileByName($name, false);
+ if ($originalName !== '') {
+ $originalFile = $this->repo->getFileByName($originalName, false);
+ }
if ($bDelete) {
$command = $vc->getCommand('rm')
->addArgument($file->getFilename())
if ($bDelete) {
$command = $vc->getCommand('rm')
->addArgument($file->getFilename())
@@
-102,13
+118,22
@@
class Repository_Post
$bCommit = true;
} else if ($bUpload) {
move_uploaded_file(
$bCommit = true;
} else if ($bUpload) {
move_uploaded_file(
- $_FILES['files']['tmp_name'][$num]['upload'], $file->getFullPath()
+ $_FILES['files']['tmp_name'][$num]['upload'],
+ $file->getFullPath()
);
$command = $vc->getCommand('add')
->addArgument($file->getFilename())
->execute();
$bCommit = true;
);
$command = $vc->getCommand('add')
->addArgument($file->getFilename())
->execute();
$bCommit = true;
- } else if ($bNew || (isset($arFile['content']) && $file->getContent() != $arFile['content'])) {
+ } else if ($bNew
+ || (isset($arFile['content']) && isset($originalFile)
+ && $originalFile->getContent() != $arFile['content']
+ )
+ ) {
+ $dir = dirname($file->getFullPath());
+ if (!is_dir($dir)) {
+ mkdir($dir, 0777, true);
+ }
file_put_contents($file->getFullPath(), $arFile['content']);
$command = $vc->getCommand('add')
->addArgument($file->getFilename())
file_put_contents($file->getFullPath(), $arFile['content']);
$command = $vc->getCommand('add')
->addArgument($file->getFilename())
@@
-117,8
+142,6
@@
class Repository_Post
}
}
}
}
- $commitmsg = "phorkie commit";
-
if (isset($sessionData['identity'])) {
$notes = $sessionData['identity'];
} else {
if (isset($sessionData['identity'])) {
$notes = $sessionData['identity'];
} else {
@@
-127,15
+150,28
@@
class Repository_Post
if ($bCommit) {
$vc->getCommand('commit')
if ($bCommit) {
$vc->getCommand('commit')
- ->setOption('message', $commitmsg)
- ->setOption('author', $sessionData['name'].' <'.$sessionData['email'].'>')
+ ->setOption('message', '')
+ ->setOption('allow-empty-message')
+ ->setOption('no-edit')
+ ->setOption(
+ 'author',
+ $sessionData['name'] . ' <' . $sessionData['email'] . '>'
+ )
->execute();
//FIXME: git needs ref BEFORE add
//quick hack until http://pear.php.net/bugs/bug.php?id=19605 is fixed
->execute();
//FIXME: git needs ref BEFORE add
//quick hack until http://pear.php.net/bugs/bug.php?id=19605 is fixed
+ //also waiting for https://pear.php.net/bugs/bug.php?id=19623
$vc->getCommand('notes --ref=identity add')
$vc->getCommand('notes --ref=identity add')
-
->setOption('force')
+ ->setOption('force')
->setOption('message', "$notes")
->execute();
->setOption('message', "$notes")
->execute();
+ //update info for dumb git HTTP transport
+ //the post-update hook should do that IMO, but does not somehow
+ $vc->getCommand('update-server-info')->execute();
+
+ //we changed the hash by committing, so reload it
+ $this->repo->reloadHash();
+
$bChanged = true;
}
$bChanged = true;
}
@@
-143,10
+179,18
@@
class Repository_Post
//FIXME: index changed files only
//also handle file deletions
$db = new Database();
//FIXME: index changed files only
//also handle file deletions
$db = new Database();
+ $not = new Notificator();
if ($bNew) {
$db->getIndexer()->addRepo($this->repo);
if ($bNew) {
$db->getIndexer()->addRepo($this->repo);
+ $not->create($this->repo);
} else {
} else {
- $db->getIndexer()->updateRepo($this->repo);
+ $commits = $this->repo->getHistory();
+ $db->getIndexer()->updateRepo(
+ $this->repo,
+ $commits[count($commits)-1]->committerTime,
+ $commits[0]->committerTime
+ );
+ $not->edit($this->repo);
}
}
}
}
@@
-159,7
+203,15
@@
class Repository_Post
if ($_FILES['files']['error'][$num]['upload'] == 0) {
return true;
}
if ($_FILES['files']['error'][$num]['upload'] == 0) {
return true;
}
- if ($arFile['content'] != '') {
+ if (isset($arFile['content']) && $arFile['content'] != '') {
+ return true;
+ }
+ if (isset($arFile['name']) && $arFile['name'] != '') {
+ //binary files do not have content
+ return true;
+ }
+ if (isset($arFile['delete']) && $arFile['delete'] != '') {
+ //binary files do not have content
return true;
}
}
return true;
}
}
@@
-174,15
+226,14
@@
class Repository_Post
$vc->getCommand('init')
//this should be setOption, but it fails with a = between name and value
->addArgument('--separate-git-dir')
$vc->getCommand('init')
//this should be setOption, but it fails with a = between name and value
->addArgument('--separate-git-dir')
- ->addArgument($GLOBALS['phorkie']['cfg']['gitdir'] . '/' . $repo->id . '.git')
+ ->addArgument(
+ $GLOBALS['phorkie']['cfg']['gitdir'] . '/' . $repo->id . '.git'
+ )
->addArgument($repo->workDir)
->execute();
->addArgument($repo->workDir)
->execute();
- foreach (glob($repo->gitDir . '/hooks/*') as $hookfile) {
- unlink($hookfile);
- }
-
- touch($repo->gitDir . '/git-daemon-export-ok');
+ $rs = new Repository_Setup($repo);
+ $rs->afterInit();
return $repo;
}
return $repo;
}
@@
-198,13
+249,23
@@
class Repository_Post
return $prefix . $num;
}
return $prefix . $num;
}
- p
rotected function getType($content
)
+ p
ublic function getType($content, $returnError = false
)
{
{
+ if (getenv('PATH') == '') {
+ //php-fpm does not fill $PATH by default
+ // we have to work around that since System::which() uses it
+ putenv('PATH=/usr/local/bin:/usr/bin:/bin');
+ }
+
$tmp = tempnam(sys_get_temp_dir(), 'phorkie-autodetect-');
file_put_contents($tmp, $content);
$tmp = tempnam(sys_get_temp_dir(), 'phorkie-autodetect-');
file_put_contents($tmp, $content);
- $type =
\
MIME_Type_PlainDetect::autoDetect($tmp);
+ $type =
Tool_
MIME_Type_PlainDetect::autoDetect($tmp);
unlink($tmp);
unlink($tmp);
+ if ($returnError && $type instanceof \PEAR_Error) {
+ return $type;
+ }
+
return $this->findExtForType($type);
}
return $this->findExtForType($type);
}